fix: Playgrounds: align webdriverio version, fix null attributes, update visual-snapshots images#2099
Conversation
Greptile SummaryThis PR fixes the playground test suites by pinning Confidence Score: 4/5Safe to merge; all changes are confined to playground test infrastructure with no impact on the library itself. Only P2 findings present (exact version pin in overrides, truthy vs null check). No logic errors or security concerns in the core library. The three
|
| Filename | Overview |
|---|---|
| playgrounds/jasmine/package.json | Adds npm overrides to pin webdriverio to 9.25.0; version is hardcoded rather than a range. |
| playgrounds/jest/package.json | Adds npm overrides to pin webdriverio to 9.25.0; version is hardcoded rather than a range. |
| playgrounds/mocha/package.json | Adds npm overrides to pin webdriverio to 9.25.0; version is hardcoded rather than a range. |
| playgrounds/jasmine/test/specs/basic-matchers.test.ts | Adds null guard for getAttribute('href') before pushing into typed array — fixes TypeScript type error and runtime issue. |
| playgrounds/jasmine/test/specs/jasmine-specific.test.ts | Applies the same null guard for getAttribute('href') as in basic-matchers. |
| playgrounds/jest/test/specs/basic-matchers.test.ts | Applies the same null guard for getAttribute('href') as in jasmine playground. |
| playgrounds/mocha/test/specs/basic-matchers.test.ts | Applies the same null guard for getAttribute('href') as in other playgrounds. |
| playgrounds/jest/test/specs/snapshots/snapshot.test.ts.snap | CSS class names updated in DOM snapshot to reflect updated WebdriverIO site markup. |
| playgrounds/mocha/test/specs/snapshots/snapshot.test.ts.snap | CSS class names updated in DOM snapshot to reflect updated WebdriverIO site markup. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[playground test run] --> B{webdriverio version conflict?}
B -- yes, before PR --> C[test failure]
B -- no, after overrides pin to 9.25.0 --> D[proceed with tests]
D --> E[getAttribute href for nav links]
E --> F{href null?}
F -- null, before PR --> G[push null into string array → type error / test failure]
F -- null, after fix --> H[skip / do not push]
F -- string --> I[push href into array]
H --> J[assertions run on valid hrefs only]
I --> J
J --> K[snapshots compared against updated baselines]
K --> L[tests pass]
Reviews (1): Last reviewed commit: "Align playground with webdriverio 9.25.0..." | Re-trigger Greptile
Playgrounds were failing